Re: [PATCH -next] btrfs: send: use list_move_tail instead of list_del/list_add_tail

[Anand Jain <anand.jain@xxxxxxxxxx>]

On 8/6/21 11:12 am, Baokun Li wrote:
> Using list_move_tail() instead of list_del() + list_add_tail().
>
> Reported-by: Hulk Robot <hulkci@xxxxxxxxxx>
> Signed-off-by: Baokun Li <libaokun1@xxxxxxxxxx>
> ---
>   fs/btrfs/send.c | 3 +--
>   1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/fs/btrfs/send.c b/fs/btrfs/send.c
> index bd69db72acc5..a0e51b2416a1 100644
> --- a/fs/btrfs/send.c
> +++ b/fs/btrfs/send.c
> @@ -2083,8 +2083,7 @@ static struct name_cache_entry *name_cache_search(struct send_ctx *sctx,
>    */
>   static void name_cache_used(struct send_ctx *sctx, struct name_cache_entry *nce)
>   {
> -	list_del(&nce->list);
> -	list_add_tail(&nce->list, &sctx->name_cache_list);
> +	list_move_tail(&nce->list, &sctx->name_cache_list);
>   }


 Looks good.
 You can consider open-code name_cache_used() as there is only one user.

Thanks, Anand

>   /*