Re: [PATCH] vdpa: fix error code in vp_vdpa_probe()

[Jason Wang <jasowang@xxxxxxxxxx>]

在 2021/6/5 下午8:47, Dan Carpenter 写道:
> Return -ENOMEM if vp_modern_map_vq_notify() fails.  Currently it
> returns success.
>
> Fixes: 11d8ffed00b2 ("vp_vdpa: switch to use vp_modern_map_vq_notify()")
> Signed-off-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx>
> ---
>   drivers/vdpa/virtio_pci/vp_vdpa.c | 1 +
>   1 file changed, 1 insertion(+)


Acked-by: Jason Wang <jasowang@xxxxxxxxxx>

Thanks


> diff --git a/drivers/vdpa/virtio_pci/vp_vdpa.c b/drivers/vdpa/virtio_pci/vp_vdpa.c
> index c76ebb531212..e5d92db728d3 100644
> --- a/drivers/vdpa/virtio_pci/vp_vdpa.c
> +++ b/drivers/vdpa/virtio_pci/vp_vdpa.c
> @@ -442,6 +442,7 @@ static int vp_vdpa_probe(struct pci_dev *pdev, const struct pci_device_id *id)
>   			vp_modern_map_vq_notify(mdev, i,
>   						&vp_vdpa->vring[i].notify_pa);
>   		if (!vp_vdpa->vring[i].notify) {
> +			ret = -ENOMEM;
>   			dev_warn(&pdev->dev, "Fail to map vq notify %d\n", i);
>   			goto err;
>   		}