The ubifs_fast_find_frdi_idx() function returns NULL on error, it doesn't return error pointers. Update the check accordingly. Fixes: 1e51764a3c2a ("UBIFS: add new flash file system") Signed-off-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx> --- fs/ubifs/gc.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/fs/ubifs/gc.c b/fs/ubifs/gc.c index dc3e26e9ed7b..7cc22d7317ea 100644 --- a/fs/ubifs/gc.c +++ b/fs/ubifs/gc.c @@ -895,8 +895,8 @@ int ubifs_gc_start_commit(struct ubifs_info *c) /* Record index freeable LEBs for unmapping after commit */ while (1) { lp = ubifs_fast_find_frdi_idx(c); - if (IS_ERR(lp)) { - err = PTR_ERR(lp); + if (!lp) { + err = -ENOMEM; goto out; } if (!lp) -- 2.30.2