On Tue, Jun 01, 2021 at 05:23:46PM -0400, Nigel Christian wrote: > On Tue, Jun 01, 2021 at 11:50:06PM +0300, Dan Carpenter wrote: > > On Tue, Jun 01, 2021 at 10:51:23PM +0300, Dan Carpenter wrote: > > > The other thing which might be interesting is if you pass a NULL > > > to IS_ERR() and then dereference the NULL then print a warning about > > > that. This has a lot of overlaps with some of my existing checks, but > > > it's still a new idea so it belongs in a separate check. It's fine and > > > good even if one bug triggers a lot of different warnings. I'll write > > > that, hang on, brb. > > > > 100% untested. :) I'll test it tonight. > > Ha, you make it look easy. Let me know if I can help with testing > Should I just add below to my smatch and recompile, > or is there an experimental branch to build from? > Yeah. :) Copy and paste that to check_null_deref_after_IS_ERR.c and add it to the check_list.h file then recompile. regards, dan carpenter
