On Tue, Jun 1, 2021 at 2:26 AM Dan Carpenter <dan.carpenter@xxxxxxxxxx> wrote:
>
> The alloc_migrate_huge_page() doesn't return error pointers, it returns
> NULL.
>
> Fixes: ab45bc8b5910 ("mm, hugetlb: fix resv_huge_pages underflow on UFFDIO_COPY")
> Signed-off-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx>
> ---
> mm/hugetlb.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
Gah, my bad.
Reviewed-by: Mina Almasry <almasrymina@xxxxxxxxxx>
> diff --git a/mm/hugetlb.c b/mm/hugetlb.c
> index 69a4b551c157..3221c94b4749 100644
> --- a/mm/hugetlb.c
> +++ b/mm/hugetlb.c
> @@ -5103,7 +5103,7 @@ int hugetlb_mcopy_atomic_pte(struct mm_struct *dst_mm,
> */
> page = alloc_migrate_huge_page(h, gfp_mask, node,
> nodemask);
> - if (IS_ERR(page)) {
> + if (!page) {
> ret = -ENOMEM;
> goto out;
> }
> --
> 2.30.2
>
