On Tue, 11 May 2021 10:19:26 +0300, Dan Carpenter wrote: > The scnprintf() function silently truncates the printf() and returns > the number bytes that it was able to copy (not counting the NUL > terminator). Thus, the highest value it can return here is > "NAME_SIZE - 1" and the overflow check is dead code. Fix this by > using the snprintf() function which returns the number of bytes that > would have been copied if there was enough space and changing the > condition from "> NAME_SIZE" to ">= NAME_SIZE". Applied, thanks! [1/1] rtc: fix snprintf() checking in is_rtc_hctosys() commit: 54b909436ede47e0ee07f1765da27ec2efa41e84 Best regards, -- Alexandre Belloni <alexandre.belloni@xxxxxxxxxxx>