On Thu, May 20, 2021 at 12:15:52PM +0100, Colin King wrote: > From: Colin Ian King <colin.king@xxxxxxxxxxxxx> > > commit af0e1871d79cfbb91f732d2c6fa7558e45c31038 upstream. > > The lux_val returned from tsl2583_get_lux can potentially be zero, > so check for this to avoid a division by zero and an overflowed > gain_trim_val. > > Fixes clang scan-build warning: > > drivers/iio/light/tsl2583.c:345:40: warning: Either the > condition 'lux_val<0' is redundant or there is division > by zero at line 345. [zerodivcond] > > Fixes: ac4f6eee8fe8 ("staging: iio: TAOS tsl258x: Device driver") > Signed-off-by: Colin Ian King <colin.king@xxxxxxxxxxxxx> > Cc: <Stable@xxxxxxxxxxxxxxx> > Signed-off-by: Jonathan Cameron <Jonathan.Cameron@xxxxxxxxxx> > [iwamatsu: Change file path.] > [Colin Ian King: minor context adjustments for 4.9.y] > Signed-off-by: Nobuhiro Iwamatsu <nobuhiro1.iwamatsu@xxxxxxxxxxxxx> > --- > drivers/staging/iio/light/tsl2583.c | 9 +++++++++ > 1 file changed, 9 insertions(+) Now queued up, thanks. greg k-