Hi Yongjun and Dan,
On Thu, May 20, 2021 at 08:32:26AM +0300, Dan Carpenter wrote:
> On Wed, May 19, 2021 at 02:16:57PM +0000, Wei Yongjun wrote:
> > 'ret' will be overwritten to 0 if erofs_sb_has_sb_chksum() return true,
> > thus 0 will return in some error handling cases. Fix to return negative
> > error code -EINVAL instead of 0.
> >
> > Reported-by: Hulk Robot <hulkci@xxxxxxxxxx>
> > Signed-off-by: Wei Yongjun <weiyongjun1@xxxxxxxxxx>
>
> You need to add Fixes tags to bug fix patches and you need to ensure
> that the authors of the Fixes commit are CC'd so they can review your
> fix. get_maintainer.pl will add the author automatically, but normally
> I like to put them in the To header to make sure they see it.
>
> Fixes: b858a4844cfb ("erofs: support superblock checksum")
The commit and the tag look good to me (sorry for a bit delay on this),
Fixes: b858a4844cfb ("erofs: support superblock checksum")
Cc: stable <stable@xxxxxxxxxxxxxxx> # 5.5+
Reviewed-by: Gao Xiang <xiang@xxxxxxxxxx>
(will apply to dev-test for a while and then to -next.)
Thanks,
Gao Xiang
