Re: [PATCH 2/2 net-next] alx: unlock on error in alx_set_pauseparam()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

To: Dan Carpenter <dan.carpenter@xxxxxxxxxx>, Chris Snook <chris.snook@xxxxxxxxx>
Subject: Re: [PATCH 2/2 net-next] alx: unlock on error in alx_set_pauseparam()
From: Johannes Berg <johannes@xxxxxxxxxxxxxxxx>
Date: Mon, 17 May 2021 11:12:40 +0200
Cc: "David S. Miller" <davem@xxxxxxxxxxxxx>, Jakub Kicinski <kuba@xxxxxxxxxx>, netdev@xxxxxxxxxxxxxxx, kernel-janitors@xxxxxxxxxxxxxxx
In-reply-to: <YKIwPe2/k1R+PTWU@mwanda>
References: <YKIwPe2/k1R+PTWU@mwanda>
User-agent: Evolution 3.38.4 (3.38.4-1.fc33)

On Mon, 2021-05-17 at 11:58 +0300, Dan Carpenter wrote:
> We need to drop the lock before returning on this error path.

Haha, how many locking errors can I have in a single patch :(

Sorry, and thanks for all the fixes!

johannes

References:
- [PATCH 2/2 net-next] alx: unlock on error in alx_set_pauseparam()
  - From: Dan Carpenter

Prev by Date: Re: [PATCH] nvmem: sprd: Fix an error message
Next by Date: Re: [PATCH V2] nvmem: core: add a missing of_node_put
Previous by thread: [PATCH 2/2 net-next] alx: unlock on error in alx_set_pauseparam()
Next by thread: [PATCH] MAINTAINERS: repair reference in DRM DRIVER FOR SIMPLE FRAMEBUFFERS
Index(es):
- Date
- Thread

[Index of Archives] [Kernel Development] [Kernel Announce] [Kernel Newbies] [Linux Networking Development] [Share Photos] [IDE] [Security] [Git] [Netfilter] [Yosemite News] [MIPS Linux] [ARM Linux] [Device Mapper]

Powered by Linux