On Sun, May 16, 2021 at 05:00:27PM +0200, Christophe JAILLET wrote:
> There is no error handling path in the probe function.
> Switch to managed resource so that errors in the probe are handled easily
> and simplify the remove function accordingly.
Either folded or separated, feel free to add to the result
Reviewed-by: Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>
> Fixes: b3c0f8774668 ("misc/pvpanic: probe multiple instances")
> Signed-off-by: Christophe JAILLET <christophe.jaillet@xxxxxxxxxx>
> ---
> drivers/misc/pvpanic/pvpanic-mmio.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/misc/pvpanic/pvpanic-mmio.c b/drivers/misc/pvpanic/pvpanic-mmio.c
> index 4c0841776087..69b31f7adf4f 100644
> --- a/drivers/misc/pvpanic/pvpanic-mmio.c
> +++ b/drivers/misc/pvpanic/pvpanic-mmio.c
> @@ -93,7 +93,7 @@ static int pvpanic_mmio_probe(struct platform_device *pdev)
> return -EINVAL;
> }
>
> - pi = kmalloc(sizeof(*pi), GFP_ATOMIC);
> + pi = devm_kmalloc(dev, sizeof(*pi), GFP_ATOMIC);
> if (!pi)
> return -ENOMEM;
>
> @@ -114,7 +114,6 @@ static int pvpanic_mmio_remove(struct platform_device *pdev)
> struct pvpanic_instance *pi = dev_get_drvdata(&pdev->dev);
>
> pvpanic_remove(pi);
> - kfree(pi);
>
> return 0;
> }
> --
> 2.30.2
>
--
With Best Regards,
Andy Shevchenko
