The Sparse tool reports as follows: drivers/base/node.c:239:1: warning: symbol 'dev_attr_line_size' was not declared. Should it be static? drivers/base/node.c:240:1: warning: symbol 'dev_attr_indexing' was not declared. Should it be static? These symbols (and several others) are defined by DEVICE_ATTR_RO(name) in CACHE_ATTR(name, fmt), and all of them are not used outside of node.c. So let's mark DEVICE_ATTR_RO(name) static to solve these complains from Sparse. Reported-by: Hulk Robot <hulkci@xxxxxxxxxx> Signed-off-by: Ruiqi Gong <gongruiqi1@xxxxxxxxxx> --- drivers/base/node.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/base/node.c b/drivers/base/node.c index f449dbb2c746..27f251c2742a 100644 --- a/drivers/base/node.c +++ b/drivers/base/node.c @@ -233,7 +233,7 @@ static ssize_t name##_show(struct device *dev, \ return sysfs_emit(buf, fmt "\n", \ to_cache_info(dev)->cache_attrs.name); \ } \ -DEVICE_ATTR_RO(name); +static DEVICE_ATTR_RO(name); CACHE_ATTR(size, "%llu") CACHE_ATTR(line_size, "%u")
