On Wed, May 12, 2021 at 3:42 PM Dan Carpenter <dan.carpenter@xxxxxxxxxx> wrote:
>
> This function is called from ethtool_set_rxfh() and "*rss_context"
> comes from the user. Add some bounds checking to prevent memory
> corruption.
>
> Fixes: 81a4362016e7 ("octeontx2-pf: Add RSS multi group support")
> Signed-off-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx>
> ---
> drivers/net/ethernet/marvell/octeontx2/nic/otx2_ethtool.c | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/drivers/net/ethernet/marvell/octeontx2/nic/otx2_ethtool.c b/drivers/net/ethernet/marvell/octeontx2/nic/otx2_ethtool.c
> index f4962a97a075..9d9a2e438acf 100644
> --- a/drivers/net/ethernet/marvell/octeontx2/nic/otx2_ethtool.c
> +++ b/drivers/net/ethernet/marvell/octeontx2/nic/otx2_ethtool.c
> @@ -786,6 +786,10 @@ static int otx2_set_rxfh_context(struct net_device *dev, const u32 *indir,
> if (hfunc != ETH_RSS_HASH_NO_CHANGE && hfunc != ETH_RSS_HASH_TOP)
> return -EOPNOTSUPP;
>
> + if (*rss_context != ETH_RXFH_CONTEXT_ALLOC &&
> + *rss_context >= MAX_RSS_GROUPS)
> + return -EINVAL;
> +
> rss = &pfvf->hw.rss_info;
>
> if (!rss->enable) {
> --
> 2.30.2
>
Acked-by: Sunil Goutham <sgoutham@xxxxxxxxxxx>
