On Tue, 2021-04-20 at 08:44:51 UTC, Dan Carpenter wrote: > Smatch complains that the error code is not set on this error path: > > drivers/mtd/nand/raw/nand_base.c:842 nand_setup_interface() > warn: missing error code 'ret' > > But actually returning success is intentional because the NAND chip will > still work in mode 0. This patch adds a "ret = 0;" assignment to make > the intent more clear and to silence the static checker warning. It > doesn't affect the compiled code because GCC optimises the assignment > away. > > Signed-off-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx> Applied to https://git.kernel.org/pub/scm/linux/kernel/git/mtd/linux.git nand/next, thanks. Miquel