On Mon, May 10, 2021 at 07:03:59AM +0200, Julia Lawall wrote:
>
>
> On Mon, 10 May 2021, Dan Carpenter wrote:
>
> > On Sun, May 09, 2021 at 11:17:42PM +0200, Julia Lawall wrote:
> > > ---------------------------
> > >
> > > Patch of a recent linux next:
> > >
> > > diff --git a/arch/arm/mach-pxa/cm-x300.c b/arch/arm/mach-pxa/cm-x300.c
> > > index 2e35354b61f5..ff75e928772a 100644
> > > --- a/arch/arm/mach-pxa/cm-x300.c
> > > +++ b/arch/arm/mach-pxa/cm-x300.c
> > > @@ -531,7 +531,7 @@ static int cm_x300_u2d_init(struct device *dev)
> > > pout_clk = clk_get(NULL, "CLK_POUT");
> > > if (IS_ERR(pout_clk)) {
> > > err = PTR_ERR(pout_clk);
> > > - pr_err("failed to get CLK_POUT: %d\n", err);
> > > + pr_err("failed to get CLK_POUT: %pe\n", err);
> >
> > It has to print the pointer and not the err. So it should be:
> >
> > pr_err("failed to get CLK_POUT: %pe\n", pout_clk);
>
> Oops! Thanks. That is easy to fix.
Yeah, but I would prefer to wait until %e exists and use that instead.
regards,
dan carpenter
