Re: [RFC 1/2] rtc: max77686: use symbolic error messages

[Christophe JAILLET <christophe.jaillet@xxxxxxxxxx>]

Le 09/05/2021 à 02:41, Edmundo Carmona Antoranz a écrit :
> Modify some error messages so that the symbolic error value be
> printed instead of a numeric value.
> ---
>   drivers/rtc/rtc-max77686.c | 6 ++++--
>   1 file changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/rtc/rtc-max77686.c b/drivers/rtc/rtc-max77686.c
> index ce089ed934ad..470260478752 100644
> --- a/drivers/rtc/rtc-max77686.c
> +++ b/drivers/rtc/rtc-max77686.c
> @@ -711,7 +711,8 @@ static int max77686_init_rtc_regmap(struct max77686_rtc_info *info)
>   						info->drv_data->regmap_config);
>   	if (IS_ERR(info->rtc_regmap)) {
>   		ret = PTR_ERR(info->rtc_regmap);
> -		dev_err(info->dev, "Failed to allocate RTC regmap: %d\n", ret);
> +		dev_err(info->dev, "Failed to allocate RTC regmap: %pe\n",
> +			info->rtc_regmap);
>   		return ret;
>   	}
>   
> @@ -763,7 +764,8 @@ static int max77686_rtc_probe(struct platform_device *pdev)
>   
>   	if (IS_ERR(info->rtc_dev)) {
>   		ret = PTR_ERR(info->rtc_dev);
> -		dev_err(&pdev->dev, "Failed to register RTC device: %d\n", ret);
> +		dev_err(&pdev->dev, "Failed to register RTC device: %pe\n",
> +			info->rtc_dev);
>   		goto err_rtc;
>   	}
>   
Hi,
both patches LGTM.

CJ