On Fri, Apr 09, 2021 at 09:49:01AM +0000, Wei Yongjun wrote: > In case of error, the function devm_kasprintf() returns NULL > pointer not ERR_PTR(). The IS_ERR() test in the return value > check should be replaced with NULL test. > > Reported-by: Hulk Robot <hulkci@xxxxxxxxxx> > Signed-off-by: Wei Yongjun <weiyongjun1@xxxxxxxxxx> > --- > v1 -> v2: remove fixes tag. > --- > drivers/hwtracing/coresight/coresight-trbe.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > I have picked up both patches. Thanks, Mathieu > diff --git a/drivers/hwtracing/coresight/coresight-trbe.c b/drivers/hwtracing/coresight/coresight-trbe.c > index 5ce239875c98..176868496879 100644 > --- a/drivers/hwtracing/coresight/coresight-trbe.c > +++ b/drivers/hwtracing/coresight/coresight-trbe.c > @@ -871,7 +871,7 @@ static void arm_trbe_register_coresight_cpu(struct trbe_drvdata *drvdata, int cp > > dev = &cpudata->drvdata->pdev->dev; > desc.name = devm_kasprintf(dev, GFP_KERNEL, "trbe%d", cpu); > - if (IS_ERR(desc.name)) > + if (!desc.name) > goto cpu_clear; > > desc.type = CORESIGHT_DEV_TYPE_SINK; >
