Hi,
On Sat, Apr 10, 2021 at 12:42:43PM +0200, Maximilian Luz wrote:
> On 4/10/21 6:12 AM, Qiheng Lin wrote:
> > The sparse tool complains as follows:
> >
> > drivers/power/supply/surface_charger.c:229:1: warning:
> > symbol 'surface_ac_pm_ops' was not declared. Should it be static?
> >
> > This symbol is not used outside of surface_charger.c, so this
> > commit marks it static.
> >
> > Reported-by: Hulk Robot <hulkci@xxxxxxxxxx>
> > Signed-off-by: Qiheng Lin <linqiheng@xxxxxxxxxx>
>
> Acked-by: Maximilian Luz <luzmaximilian@xxxxxxxxx>
Thanks, queued.
-- Sebastian
> > ---
> > drivers/power/supply/surface_charger.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/power/supply/surface_charger.c b/drivers/power/supply/surface_charger.c
> > index c2dd7e604d14..81a5b79822c9 100644
> > --- a/drivers/power/supply/surface_charger.c
> > +++ b/drivers/power/supply/surface_charger.c
> > @@ -226,7 +226,7 @@ static int __maybe_unused surface_ac_resume(struct device *dev)
> > {
> > return spwr_ac_recheck(dev_get_drvdata(dev));
> > }
> > -SIMPLE_DEV_PM_OPS(surface_ac_pm_ops, NULL, surface_ac_resume);
> > +static SIMPLE_DEV_PM_OPS(surface_ac_pm_ops, NULL, surface_ac_resume);
> > static int surface_ac_probe(struct ssam_device *sdev)
> > {
> >
Attachment:
signature.asc
Description: PGP signature
