Re: [PATCH -next] power: supply: Make some symbols static

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 4/10/21 6:12 AM, Qiheng Lin wrote:
The sparse tool complains as follows:

drivers/power/supply/surface_battery.c:700:1: warning:
  symbol 'dev_attr_alarm' was not declared. Should it be static?
drivers/power/supply/surface_battery.c:805:1: warning:
  symbol 'surface_battery_pm_ops' was not declared. Should it be static?

This symbol is not used outside of surface_battery.c, so this
commit marks it static.

Reported-by: Hulk Robot <hulkci@xxxxxxxxxx>
Signed-off-by: Qiheng Lin <linqiheng@xxxxxxxxxx>

Acked-by: Maximilian Luz <luzmaximilian@xxxxxxxxx>

---
  drivers/power/supply/surface_battery.c | 4 ++--
  1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/power/supply/surface_battery.c b/drivers/power/supply/surface_battery.c
index 4116dd839ecd..7efa431a62b2 100644
--- a/drivers/power/supply/surface_battery.c
+++ b/drivers/power/supply/surface_battery.c
@@ -697,7 +697,7 @@ static ssize_t alarm_store(struct device *dev, struct device_attribute *attr, co
  	return count;
  }
-DEVICE_ATTR_RW(alarm);
+static DEVICE_ATTR_RW(alarm);
static struct attribute *spwr_battery_attrs[] = {
  	&dev_attr_alarm.attr,
@@ -802,7 +802,7 @@ static int __maybe_unused surface_battery_resume(struct device *dev)
  {
  	return spwr_battery_recheck_full(dev_get_drvdata(dev));
  }
-SIMPLE_DEV_PM_OPS(surface_battery_pm_ops, NULL, surface_battery_resume);
+static SIMPLE_DEV_PM_OPS(surface_battery_pm_ops, NULL, surface_battery_resume);
static int surface_battery_probe(struct ssam_device *sdev)
  {




[Index of Archives]     [Kernel Development]     [Kernel Announce]     [Kernel Newbies]     [Linux Networking Development]     [Share Photos]     [IDE]     [Security]     [Git]     [Netfilter]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Device Mapper]

  Powered by Linux