On Wed, Apr 07, 2021 at 09:32:14PM +0200, Sergei Krainov wrote:
> Remove unused variable from rtl871x_mlme.c
>
> Signed-off-by: Sergei Krainov <sergei.krainov.lkd@xxxxxxxxx>
> ---
> drivers/staging/rtl8712/rtl871x_mlme.c | 9 +--------
> 1 file changed, 1 insertion(+), 8 deletions(-)
>
> diff --git a/drivers/staging/rtl8712/rtl871x_mlme.c b/drivers/staging/rtl8712/rtl871x_mlme.c
> index 8a97307fbbd6..4f41e321ea63 100644
> --- a/drivers/staging/rtl8712/rtl871x_mlme.c
> +++ b/drivers/staging/rtl8712/rtl871x_mlme.c
> @@ -656,7 +656,7 @@ void r8712_joinbss_event_callback(struct _adapter *adapter, u8 *pbuf)
> struct sta_priv *pstapriv = &adapter->stapriv;
> struct mlme_priv *pmlmepriv = &adapter->mlmepriv;
> struct wlan_network *cur_network = &pmlmepriv->cur_network;
> - struct wlan_network *pcur_wlan = NULL, *ptarget_wlan = NULL;
> + struct wlan_network *ptarget_wlan = NULL;
> unsigned int the_same_macaddr = false;
> struct wlan_network *pnetwork;
>
> @@ -721,13 +721,6 @@ void r8712_joinbss_event_callback(struct _adapter *adapter, u8 *pbuf)
> scanned_queue,
> cur_network->network.MacAddress);
> } else {
> - pcur_wlan =
> - r8712_find_network(&pmlmepriv->
> - scanned_queue,
> - cur_network->network.MacAddress);
> - if (pcur_wlan)
> - pcur_wlan->fixed = false;
> -
Are you sure that r8712_find_network() does not have some other
side-affect here? Please doucment that in the changelog text.
thanks,
greg k-h
