There is a error message within devm_ioremap_resource already, so remove the dev_err call to avoid redundant error message. Reported-by: Hulk Robot <hulkci@xxxxxxxxxx> Signed-off-by: Wei Li <liwei391@xxxxxxxxxx> --- drivers/gpu/drm/hisilicon/kirin/kirin_drm_ade.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/gpu/drm/hisilicon/kirin/kirin_drm_ade.c b/drivers/gpu/drm/hisilicon/kirin/kirin_drm_ade.c index 6dcf9ec05eec..78a792048c42 100644 --- a/drivers/gpu/drm/hisilicon/kirin/kirin_drm_ade.c +++ b/drivers/gpu/drm/hisilicon/kirin/kirin_drm_ade.c @@ -857,10 +857,8 @@ static void *ade_hw_ctx_alloc(struct platform_device *pdev, res = platform_get_resource(pdev, IORESOURCE_MEM, 0); ctx->base = devm_ioremap_resource(dev, res); - if (IS_ERR(ctx->base)) { - DRM_ERROR("failed to remap ade io base\n"); + if (IS_ERR(ctx->base)) return ERR_PTR(-EIO); - } ctx->reset = devm_reset_control_get(dev, NULL); if (IS_ERR(ctx->reset))