> -----Original Message----- > From: Christophe JAILLET <christophe.jaillet@xxxxxxxxxx> > Sent: Sunday, April 4, 2021 6:13 PM > To: Ariel Elior <aelior@xxxxxxxxxxx>; GR-everest-linux-l2 <GR-everest-linux- > l2@xxxxxxxxxxx>; davem@xxxxxxxxxxxxx; kuba@xxxxxxxxxx > Cc: netdev@xxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx; kernel- > janitors@xxxxxxxxxxxxxxx; Christophe JAILLET <christophe.jaillet@xxxxxxxxxx> > Subject: [EXT] [PATCH 1/2] qede: Remove a erroneous ++ in > 'qede_rx_build_jumbo()' > > External Email > > ---------------------------------------------------------------------- > This ++ is confusing. It looks duplicated with the one already performed in > 'skb_fill_page_desc()'. > > In fact, it is harmless. 'nr_frags' is written twice with the same value. > Once, because of the nr_frags++, and once because of the 'nr_frags = i + 1' > in 'skb_fill_page_desc()'. > > So axe this post-increment to avoid confusion. > > Signed-off-by: Christophe JAILLET <christophe.jaillet@xxxxxxxxxx> > --- > drivers/net/ethernet/qlogic/qede/qede_fp.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/net/ethernet/qlogic/qede/qede_fp.c > b/drivers/net/ethernet/qlogic/qede/qede_fp.c > index 102d0e0808d5..ee3e45e38cb7 100644 > --- a/drivers/net/ethernet/qlogic/qede/qede_fp.c > +++ b/drivers/net/ethernet/qlogic/qede/qede_fp.c > @@ -1209,7 +1209,7 @@ static int qede_rx_build_jumbo(struct qede_dev > *edev, > dma_unmap_page(rxq->dev, bd->mapping, > PAGE_SIZE, DMA_FROM_DEVICE); > > - skb_fill_page_desc(skb, skb_shinfo(skb)->nr_frags++, > + skb_fill_page_desc(skb, skb_shinfo(skb)->nr_frags, > bd->data, rxq->rx_headroom, cur_size); > > skb->truesize += PAGE_SIZE; > -- > 2.27.0 Acked-by: Manish Chopra <manishc@xxxxxxxxxxx>
