Re: [Linux-cifsd-devel] [PATCH] cifsd: use kfree to free memory allocated by kzalloc

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Am 4/1/21 um 2:43 PM schrieb Namjae Jeon:
2021-04-01 20:50 GMT+09:00, Dan Carpenter <dan.carpenter@xxxxxxxxxx>:
On Thu, Apr 01, 2021 at 04:39:33PM +0500, Muhammad Usama Anjum wrote:
kfree should be used to free memory allocated by kzalloc to avoid
any overhead and for maintaining consistency.

Fixes: 5dfeb6d945 ("cifsd: use kmalloc() for small allocations")
Signed-off-by: Muhammad Usama Anjum <musamaanjum@xxxxxxxxx>
---
This one place was left in earlier patch. I've already received
responsse on that patch. I'm sending a separate patch.

  fs/cifsd/transport_tcp.c | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/fs/cifsd/transport_tcp.c b/fs/cifsd/transport_tcp.c
index 67163efcf472..040881893417 100644
--- a/fs/cifsd/transport_tcp.c
+++ b/fs/cifsd/transport_tcp.c
@@ -551,7 +551,7 @@ void ksmbd_tcp_destroy(void)
  	list_for_each_entry_safe(iface, tmp, &iface_list, entry) {
  		list_del(&iface->entry);
  		kfree(iface->name);
-		ksmbd_free(iface);
+		kfree(iface);

We should just delete the ksmbd_free() function completely.
Yes, I have added your review comment about this to my todo-list.
I will do that.

I think that cifsd is being re-written though so it might not be worth
it.
Right.

fwiw, while at it what about renaming everything that still references "cifs" to "smb" ? This is not the 90's... :)

Cheers!
-slow

Attachment: OpenPGP_signature
Description: OpenPGP digital signature


[Index of Archives]     [Kernel Development]     [Kernel Announce]     [Kernel Newbies]     [Linux Networking Development]     [Share Photos]     [IDE]     [Security]     [Git]     [Netfilter]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Device Mapper]

  Powered by Linux