On Fri, Mar 26, 2021 at 06:17:32PM -0600, Edmundo Carmona Antoranz wrote:
> The variable *pframe in rtw_build_wmm_ie_ht() and rtw_restructure_ht_ie()
> is set but never read. Both instances are getting removed.
>
> Removing these warning:
>
> drivers/staging/rtl8723bs/core/rtw_mlme.c:2560:6: warning: variable ‘pframe’ set but not used [-Wunused-but-set-variable]
> drivers/staging/rtl8723bs/core/rtw_mlme.c:2576:21: warning: variable ‘pframe’ set but not used [-Wunused-but-set-variable]
>
> Signed-off-by: Edmundo Carmona Antoranz <eantoranz@xxxxxxxxx>
> ---
> drivers/staging/rtl8723bs/core/rtw_mlme.c | 14 +++++++-------
> 1 file changed, 7 insertions(+), 7 deletions(-)
>
> diff --git a/drivers/staging/rtl8723bs/core/rtw_mlme.c b/drivers/staging/rtl8723bs/core/rtw_mlme.c
> index 29d4b7493784..83fbd415d766 100644
> --- a/drivers/staging/rtl8723bs/core/rtw_mlme.c
> +++ b/drivers/staging/rtl8723bs/core/rtw_mlme.c
> @@ -2555,12 +2555,11 @@ void rtw_build_wmm_ie_ht(struct adapter *padapter, u8 *out_ie, uint *pout_len)
> {
> unsigned char WMM_IE[] = {0x00, 0x50, 0xf2, 0x02, 0x00, 0x01, 0x00};
> int out_len;
> - u8 *pframe;
>
> if (padapter->mlmepriv.qospriv.qos_option == 0) {
> out_len = *pout_len;
> - pframe = rtw_set_ie(out_ie+out_len, WLAN_EID_VENDOR_SPECIFIC,
> - _WMM_IE_Length_, WMM_IE, pout_len);
> + rtw_set_ie(out_ie + out_len, WLAN_EID_VENDOR_SPECIFIC,
> + _WMM_IE_Length_, WMM_IE, pout_len);
Why not check the error value?
thanks,
greg k-h
