From: Lifu Chen <chenlifu@xxxxxxxxxx> spinlock can be initialized automatically with DEFINE_SPINLOCK() rather than explicitly calling spin_lock_init(). Reported-by: Hulk Robot <hulkci@xxxxxxxxxx> Signed-off-by: Lifu Chen <chenlifu@xxxxxxxxxx> --- arch/arm/mach-sa1100/simpad.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/arch/arm/mach-sa1100/simpad.c b/arch/arm/mach-sa1100/simpad.c index c7fb9a73e4c5..c183432880d3 100644 --- a/arch/arm/mach-sa1100/simpad.c +++ b/arch/arm/mach-sa1100/simpad.c @@ -45,7 +45,7 @@ */ static long cs3_shadow; -static spinlock_t cs3_lock; +static DEFINE_SPINLOCK(cs3_lock); static struct gpio_chip cs3_gpio; long simpad_get_cs3_ro(void) @@ -379,8 +379,6 @@ static int __init simpad_init(void) { int ret; - spin_lock_init(&cs3_lock); - cs3_gpio.label = "simpad_cs3"; cs3_gpio.base = SIMPAD_CS3_GPIO_BASE; cs3_gpio.ngpio = 24;