Re: [PATCH] platform/surface: clean up a variable in surface_dtx_read()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 3/26/21 1:28 PM, Dan Carpenter wrote:
The "&client->ddev->lock" and "&ddev->lock" are the same thing.  Let's
use "&ddev->lock" consistently.

Signed-off-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx>

Good catch, thanks!

Reviewed-by: Maximilian Luz <luzmaximilian@xxxxxxxxx>

---
  drivers/platform/surface/surface_dtx.c | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/platform/surface/surface_dtx.c b/drivers/platform/surface/surface_dtx.c
index 1fedacf74050..63ce587e79e3 100644
--- a/drivers/platform/surface/surface_dtx.c
+++ b/drivers/platform/surface/surface_dtx.c
@@ -487,7 +487,7 @@ static ssize_t surface_dtx_read(struct file *file, char __user *buf, size_t coun
  			if (status < 0)
  				return status;
- if (down_read_killable(&client->ddev->lock))
+			if (down_read_killable(&ddev->lock))
  				return -ERESTARTSYS;
/* Need to check that we're not shut down again. */




[Index of Archives]     [Kernel Development]     [Kernel Announce]     [Kernel Newbies]     [Linux Networking Development]     [Share Photos]     [IDE]     [Security]     [Git]     [Netfilter]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Device Mapper]

  Powered by Linux