Re: [PATCH -next] mm/page_alloc: remove duplicated include from page_alloc.c

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hey, Matthew

Thanks for your advice towards hulk robot. We'd like to improve the capbility of hulk robot whole the time.

This patch is just a small cleanup reported by hulk robot, But the robot can do more than this. For example, it finds crucial and useful bugs as well.

As for 'Untangle the mass of header includes' you mentioned, could you please offer more details? Because I didn't find pagemap.h in net/ipv4/tcp.c in -next like what you said.


在 2021/3/26 11:42, Matthew Wilcox 写道:
On Fri, Mar 26, 2021 at 10:55:42AM +0800, Qinglang Miao wrote:
Remove duplicated include.

Reported-by: Hulk Robot <hulkci@xxxxxxxxxx>
Signed-off-by: Qinglang Miao <miaoqinglang@xxxxxxxxxx>

can't you make hulk robot do something useful, like untangle the
mass of header includes?  For example, in -next, net/ipv4/tcp.c
has a dependency on pagemap.h.  Why?
.




[Index of Archives]     [Kernel Development]     [Kernel Announce]     [Kernel Newbies]     [Linux Networking Development]     [Share Photos]     [IDE]     [Security]     [Git]     [Netfilter]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Device Mapper]

  Powered by Linux