On Wed, Mar 24, 2021 at 03:09:50PM +0000, Colin King wrote: > From: Colin Ian King <colin.king@xxxxxxxxxxxxx> > > The call to br_vlan_replay_one is returning an error return value but > this is not being assigned to err and the following check on err is > currently always false because err was initialized to zero. Fix this > by assigning err. > > Addresses-Coverity: ("'Constant' variable guards dead code") > Fixes: 22f67cdfae6a ("net: bridge: add helper to replay VLANs installed on port") > Signed-off-by: Colin Ian King <colin.king@xxxxxxxxxxxxx> > --- Reviewed-by: Vladimir Oltean <vladimir.oltean@xxxxxxx>