From: Wei Yongjun <weiyongjun1@xxxxxxxxxx> The sparse tool complains as follows: drivers/nvdimm/security.c:416:6: warning: symbol '__nvdimm_security_overwrite_query' was not declared. Should it be static? This symbol is not used outside of security.c, so this commit marks it static. Reported-by: Hulk Robot <hulkci@xxxxxxxxxx> Signed-off-by: Wei Yongjun <weiyongjun1@xxxxxxxxxx> --- drivers/nvdimm/security.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/nvdimm/security.c b/drivers/nvdimm/security.c index 4b80150e4afa..d3e782662bf4 100644 --- a/drivers/nvdimm/security.c +++ b/drivers/nvdimm/security.c @@ -413,7 +413,7 @@ static int security_overwrite(struct nvdimm *nvdimm, unsigned int keyid) return rc; } -void __nvdimm_security_overwrite_query(struct nvdimm *nvdimm) +static void __nvdimm_security_overwrite_query(struct nvdimm *nvdimm) { struct nvdimm_bus *nvdimm_bus = walk_to_nvdimm_bus(&nvdimm->dev); int rc;