Dan Carpenter <dan.carpenter@xxxxxxxxxx> wrote:
> The sscanf() function returns either 0 or 1 here. It doesn't return
> error codes. We should return -EINVAL if the string is invalid.
>
> Fixes: c376c1fc87b7 ("rtw88: add h2c command in debugfs")
> Signed-off-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx>
Why do you remove the num variable? I think the code is more readable with it.
(Sorry, I'm not able to quote the code as I'm replying from patchwork script
and it doesn't support that yet.)
--
https://patchwork.kernel.org/project/linux-wireless/patch/YCwgb/4F4Y+tyE56@mwanda/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
