On Mon, Mar 08, 2021 at 09:48:39AM +0000, 'Wei Yongjun wrote:
> From: Wei Yongjun <weiyongjun1@xxxxxxxxxx>
>
> In case of error, the function device_get_named_child_node() returns
> NULL pointer not ERR_PTR(). The IS_ERR() test in the return value check
> should be replaced with NULL test.
>
> Fixes: da0cb6310094 ("usb: typec: add support for STUSB160x Type-C controller family")
> Reported-by: Hulk Robot <hulkci@xxxxxxxxxx>
> Signed-off-by: Wei Yongjun <weiyongjun1@xxxxxxxxxx>
Reviewed-by: Heikki Krogerus <heikki.krogerus@xxxxxxxxxxxxxxx>
> ---
> drivers/usb/typec/stusb160x.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/usb/typec/stusb160x.c b/drivers/usb/typec/stusb160x.c
> index d21750bbbb44..6eaeba9b096e 100644
> --- a/drivers/usb/typec/stusb160x.c
> +++ b/drivers/usb/typec/stusb160x.c
> @@ -682,8 +682,8 @@ static int stusb160x_probe(struct i2c_client *client)
> }
>
> fwnode = device_get_named_child_node(chip->dev, "connector");
> - if (IS_ERR(fwnode))
> - return PTR_ERR(fwnode);
> + if (!fwnode)
> + return -ENODEV;
>
> /*
> * When both VDD and VSYS power supplies are present, the low power
thanks,
--
heikki
