Hi Dan, On Tue, Feb 09, 2021 at 02:04:48PM +0300, Dan Carpenter wrote: > The "ret" variable is uninitialized in this error message. > > Fixes: 9746b11715c3 ("media: i2c: Add imx334 camera sensor driver") > Signed-off-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx> Thanks for the patch. This has been already addressed by a patch from Hans (but not merged yet): <URL:https://patchwork.linuxtv.org/project/linux-media/patch/917ccfef-b93e-4d90-0b5a-4974145ab187@xxxxxxxxx/> > --- > When new drivers are merged into the kernel, then could we use the > driver prefix? In other words something like this: > > media: i2c/imx334: Add imx334 camera sensor driver We've usually had driver's name and Mauro's scripts add media: prefix --- unless it's already there. Are you suggesting also the bus should be part of it? -- Kind regards, Sakari Ailus