Hi Dan, Thanks for a patch. > -----Original Message----- > From: Dan Carpenter <dan.carpenter@xxxxxxxxxx> > Sent: Monday, January 25, 2021 2:14 PM > To: Nilesh Javali <njavali@xxxxxxxxxxx> > Cc: GR-QLogic-Storage-Upstream <GR-QLogic-Storage- > Upstream@xxxxxxxxxxx>; James E.J. Bottomley <jejb@xxxxxxxxxxxxx>; > Martin K. Petersen <martin.petersen@xxxxxxxxxx>; Himanshu Madhani > <himanshu.madhani@xxxxxxxxxx>; Saurav Kashyap > <skashyap@xxxxxxxxxxx>; linux-scsi@xxxxxxxxxxxxxxx; linux- > kernel@xxxxxxxxxxxxxxx; kernel-janitors@xxxxxxxxxxxxxxx > Subject: [EXT] [PATCH] scsi: qla2xxx: fix some memory corruption > > External Email > > ---------------------------------------------------------------------- > This was supposed to be "data" instead of "&data". The current code > will corrupt the stack. > > Fixes: dbf1f53cfd23 ("scsi: qla2xxx: Implementation to get and manage host, > target stats and initiator port") > Signed-off-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx> > --- > drivers/scsi/qla2xxx/qla_bsg.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/scsi/qla2xxx/qla_bsg.c b/drivers/scsi/qla2xxx/qla_bsg.c > index e45da05383cd..bee8cf9f8123 100644 > --- a/drivers/scsi/qla2xxx/qla_bsg.c > +++ b/drivers/scsi/qla2xxx/qla_bsg.c > @@ -2667,7 +2667,7 @@ qla2x00_get_tgt_stats(struct bsg_job *bsg_job) > > bsg_reply->reply_payload_rcv_len = > sg_copy_from_buffer(bsg_job- > >reply_payload.sg_list, > - bsg_job->reply_payload.sg_cnt, > &data, > + bsg_job->reply_payload.sg_cnt, > data, > sizeof(struct > ql_vnd_tgt_stats_resp)); > > bsg_reply->result = DID_OK; > -- Acked-by: Saurav Kashyap <skashyap@xxxxxxxxxxx> > 2.29.2