> On Jan 25, 2021, at 03:45, Dan Carpenter <dan.carpenter@xxxxxxxxxx> wrote: > > The devm_memremap() function never returns NULL, it returns error > pointers so the test needs to be fixed. Also we need to call > pci_release_regions() to avoid a memory leak. > > Fixes: be4f77ac6884 ("drm/vmwgfx: Cleanup fifo mmio handling") > Signed-off-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx> Thanks, Dan. I have a patch based on your report that fixes that too but it comes with a refactoring. I’d be happy to rebase it on top of yours just to get yours in before. If you’d like I can push your patch through drm-misc-next, if not: Reviewed-by: Zack Rusin <zackr@xxxxxxxxxx> z