Dan, > The list iterator can't be NULL so this check is not required. Removing > the check silences a Smatch warning about inconsistent NULL checking. > > drivers/scsi/qla2xxx/qla_dfs.c:371 qla_dfs_tgt_counters_show() > error: we previously assumed 'fcport' could be null (see line 372) Applied to 5.12/scsi-staging, thanks! -- Martin K. Petersen Oracle Linux Engineering