On 11/01/2021 16:35, Mark Brown wrote: > On Fri, Jan 08, 2021 at 12:35:46PM +0000, Colin King wrote: >> From: Colin Ian King <colin.king@xxxxxxxxxxxxx> >> >> Currently when attempting to start the BE fails because the >> FE is not started the error return variable ret is not initialized >> and garbage is returned. Fix this by setting it to 0 so the > > This doesn't apply against current code, please check and resend. > Current ASoC tree now has two commits: commit 4eeed5f40354735c4e68e71904db528ed19c9cbb Author: Souptick Joarder <jrdr.linux@xxxxxxxxx> Date: Sat Jan 9 09:15:01 2021 +0530 ASoC: soc-pcm: return correct -ERRNO in failure path commit e91b65b36fde0690f1c694f17dd1b549295464a7 Author: Dan Carpenter <dan.carpenter@xxxxxxxxxx> Date: Mon Jan 11 12:50:21 2021 +0300 ASoC: soc-pcm: Fix an uninitialized error code ..both set ret to non-zero, which I believe will throw a subsequent warning messagethat's not strictly related. my fix was acked by zhucancan@xxxxxxxx, so I'm now confused what is the *correct* fix. Colin