On Tue, Dec 15, 2020 at 09:56:55AM +0100, Maxime Ripard wrote: > Hi, > > On Mon, Dec 14, 2020 at 09:21:17PM +0100, Christophe JAILLET wrote: > > 'irq_of_parse_and_map()' should be balanced by a corresponding > > 'irq_dispose_mapping()' call. Otherwise, there is some resources leaks. > > Do you have a source to back that? It's not clear at all from the > documentation for those functions, and couldn't find any user calling it > from the ten-or-so random picks I took. It looks like irq_create_of_mapping() needs to be freed with irq_dispose_mapping() so this is correct. regards, dan carpenter