On 12/12/2020 10:20 AM, Christophe JAILLET wrote: > If the 'register_netdev()' call fails, we must undo a previous > 'bcmgenet_mii_init()' call. > > Fixes: 1c1008c793fa ("net: bcmgenet: add main driver file")> Signed-off-by: Christophe JAILLET <christophe.jaillet@xxxxxxxxxx> Acked-by: Florian Fainelli <f.fainelli@xxxxxxxxx> > --- > The missing 'bcmgenet_mii_exit()' call is added here, instead of in the > error handling path in order to avoid some goto spaghetti code. Yes that makes sense, thanks! -- Florian