Thanks for submitting this Dan.
Reviewed-by: Robert Foss <robert.foss@xxxxxxxxxx>
On Wed, 9 Dec 2020 at 07:51, Dan Carpenter <dan.carpenter@xxxxxxxxxx> wrote:
>
> This error path returns success but it should return -EINVAL.
>
> Fixes: cba3819d1e93 ("media: camss: Format configuration per hardware version")
> Signed-off-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx>
> ---
> drivers/media/platform/qcom/camss/camss-video.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/media/platform/qcom/camss/camss-video.c b/drivers/media/platform/qcom/camss/camss-video.c
> index 2fa3214775d5..97cea7c4d769 100644
> --- a/drivers/media/platform/qcom/camss/camss-video.c
> +++ b/drivers/media/platform/qcom/camss/camss-video.c
> @@ -961,6 +961,7 @@ int msm_video_register(struct camss_video *video, struct v4l2_device *v4l2_dev,
> video->nformats = ARRAY_SIZE(formats_rdi_8x96);
> }
> } else {
> + ret = -EINVAL;
> goto error_video_register;
> }
>
> --
> 2.29.2
>
