On Fri, 4 Dec 2020 14:57, Dan Carpenter wrote:
> 366 if (pdata->num_buck > variant_parameters[chip-
> >variant_id].num_bucks) {
> ^^
> Smatch is complaining that this sort of looks like it should be >=
> instead of >. This looks true to me as well, but I'm not positive
> enough to actually send a patch. :P
As it goes, that bit is fine - it's for if a second buck is configured on a single buck variant.
> 383 if (of_property_read_u32(da9121_matches[pdata-
> >num_buck].of_node,
> ^^^^^^^^^^^^^^^
> We know that .num_bucks is 2 here so if ->num_buck is == to that then
> this is one element beyond the end of the array.
But this is a nice catch - thank you.
Regards,
Adam
