Re: [PATCH] Staging: rtl8723bs/core: Add blank line after variable declarations.

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Dec 01, 2020 at 03:47:14PM -0600, Brother Matthew De Angelis wrote:
> Fix the checkpatch.pl warning:
> 
> rtw_security.c:2374: WARNING: Missing a blank line after declarations
> 
> Signed-off-by: Brother Matthew De Angelis <matthew.v.deangelis@xxxxxxxxx>
> ---
>  drivers/staging/rtl8723bs/core/rtw_security.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/staging/rtl8723bs/core/rtw_security.c b/drivers/staging/rtl8723bs/core/rtw_security.c
> index 159d32ace2bc..a3a6558c9e03 100644
> --- a/drivers/staging/rtl8723bs/core/rtw_security.c
> +++ b/drivers/staging/rtl8723bs/core/rtw_security.c
> @@ -2371,6 +2371,7 @@ u8 rtw_handle_tkip_countermeasure(struct adapter *adapter, const char *caller)
>  
>  	if (securitypriv->btkip_countermeasure) {
>  		unsigned long passing_ms = jiffies_to_msecs(jiffies - securitypriv->btkip_countermeasure_time);
> +
>  		if (passing_ms > 60*1000) {
>  			DBG_871X_LEVEL(_drv_always_, "%s("ADPT_FMT") countermeasure time:%lus > 60s\n",
>  				caller, ADPT_ARG(adapter), passing_ms/1000);
> -- 
> 2.25.1
> 
> Hello kernel janitors,
> 
> this is my third patch and I don't feel very confident yet. Would this patch be worth Greg's time?
> 

I already replied about this patch earlier.  Someone already sent it so
it's not needed.

These patches take about 15 seconds of Greg's time and he deliberately
leaves checkpatch warnings like this for people to practice sending him
patches.

regards,
dan carpenter




[Index of Archives]     [Kernel Development]     [Kernel Announce]     [Kernel Newbies]     [Linux Networking Development]     [Share Photos]     [IDE]     [Security]     [Git]     [Netfilter]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Device Mapper]

  Powered by Linux