On (20/11/30 16:37), Petr Mladek wrote: > On Mon 2020-11-30 13:49:15, Lukas Bulwahn wrote: [..] > > diff --git a/kernel/printk/printk.c b/kernel/printk/printk.c > > index f279d4fbd9dd..6e4e38b7cd91 100644 > > --- a/kernel/printk/printk.c > > +++ b/kernel/printk/printk.c > > @@ -741,7 +741,6 @@ static ssize_t devkmsg_write(struct kiocb *iocb, struct iov_iter *from) > > if (LOG_FACILITY(u) != 0) > > facility = LOG_FACILITY(u); > > endp++; > > - len -= endp - line; > > line = endp; > > } > > } > > Yup, it was used to write the trailing '\0'. But it is done earlier > now. So, it is not longer needed. > > Reviewed-by: Petr Mladek <pmladek@xxxxxxxx> > > Best Regards, > Petr > > PS: I'll give it few days just in case anyone else would want to > review it. I'll push it then unless anyone complains. FWIW, looks good to me Reviewed-by: Sergey Senozhatsky <sergey.senozhatsky@xxxxxxxxx> -ss
