On Thu, Nov 26, 2020 at 6:16 PM Andrew Cooper <andrew.cooper3@xxxxxxxxxx> wrote:
>
> On 26/11/2020 11:54, Lukas Bulwahn wrote:
> > Commit 1e5de18278e6 ("x86: Introduce GDT_ENTRY_INIT()") unintentionally
> > transformed a few 0xffff values to 0xfffff (note: five times "f" instead of
> > four) as part of the refactoring.
>
> The transformation in that change is correct.
>
> Segment bases are 20 bits wide in x86, but the top nibble is folded into
> the middle of the attributes, which is why the transformation also has
> xfxx => x0xx for the attributes field.
>
> >
> > A quick check with:
> >
> > git show 1e5de18278e6 | grep "fffff"
> >
> > reveals all those 14 occurrences:
> >
> > 12 in ./arch/x86/kernel/cpu/common.c, and
> > 2 in ./arch/x86/include/asm/lguest.h.
> >
> > The two occurrences in ./arch/x86/include/asm/lguest.h were deleted with
> > commit ecda85e70277 ("x86/lguest: Remove lguest support").
> > Correct the remaining twelve occurrences in ./arch/x86/kernel/cpu/common.c
> > back to the original values in the source code before the refactoring.
> >
> > Commit 866b556efa12 ("x86/head/64: Install startup GDT") probably simply
> > copied the required startup gdt information from
> > ./arch/x86/kernel/cpu/common.c to ./arch/x86/kernel/head64.c.
> > So, correct those three occurrences in ./arch/x86/kernel/head64.c as well.
> >
> > As this value is truncated anyway, the object code has not changed when
> > introducing the mistake and is also not changed with this correction now.
> >
> > This was discovered with sparse, which warns with:
> >
> > warning: cast truncates bits from constant value (fffff becomes ffff)
>
> Does:
>
> diff --git a/arch/x86/include/asm/desc_defs.h
> b/arch/x86/include/asm/desc_defs.h
> index f7e7099af595..9561f3c66e9e 100644
> --- a/arch/x86/include/asm/desc_defs.h
> +++ b/arch/x86/include/asm/desc_defs.h
> @@ -22,7 +22,7 @@ struct desc_struct {
>
> #define GDT_ENTRY_INIT(flags, base, limit) \
> { \
> - .limit0 = (u16) (limit), \
> + .limit0 = (u16) (limit) & 0xFFFF, \
> .limit1 = ((limit) >> 16) & 0x0F, \
> .base0 = (u16) (base), \
> .base1 = ((base) >> 16) & 0xFF, \
>
> fix the warning?
>
Thanks, I will try that out, and try compiling a 32-bit kernel as well.
> Changing the limit from 4G to 128M isn't going to be compatible with a
> 32bit kernel trying to boot :).
>
> ~Andrew
