From: Colin Ian King <colin.king@xxxxxxxxxxxxx> Since moving to the new debug helper functions we now have a debug message that dereferences crtc to print a kernel debug message when crtc is null and so this debug message will now cause a null pointer dereference. Since this is a debug message it probably is just simplest to fix this by just removing the debug message altogether. Addresses-Coverity: ("Dereference after null check") Fixes: e3aae683e861 ("drm: convert drm_atomic_uapi.c to new debug helpers") Signed-off-by: Colin Ian King <colin.king@xxxxxxxxxxxxx> --- drivers/gpu/drm/drm_atomic_uapi.c | 5 ----- 1 file changed, 5 deletions(-) diff --git a/drivers/gpu/drm/drm_atomic_uapi.c b/drivers/gpu/drm/drm_atomic_uapi.c index 9df7f2a170e3..3fd84590560a 100644 --- a/drivers/gpu/drm/drm_atomic_uapi.c +++ b/drivers/gpu/drm/drm_atomic_uapi.c @@ -338,11 +338,6 @@ drm_atomic_set_crtc_for_connector(struct drm_connector_state *conn_state, "Link [CONNECTOR:%d:%s] state %p to [CRTC:%d:%s]\n", connector->base.id, connector->name, conn_state, crtc->base.id, crtc->name); - } else { - drm_dbg_atomic(crtc->dev, - "Link [CONNECTOR:%d:%s] state %p to [NOCRTC]\n", - connector->base.id, connector->name, - conn_state); } return 0; -- 2.28.0