Re: [PATCH] soc: aspeed: Fix a reference leak in aspeed_socinfo_init()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

To: "Dan Carpenter" <dan.carpenter@xxxxxxxxxx>, "Joel Stanley" <joel@xxxxxxxxx>
Subject: Re: [PATCH] soc: aspeed: Fix a reference leak in aspeed_socinfo_init()
From: "Andrew Jeffery" <andrew@xxxxxxxx>
Date: Mon, 16 Nov 2020 14:40:55 +1030
Cc: "Tom Rix" <trix@xxxxxxxxxx>, linux-aspeed@xxxxxxxxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx, kernel-janitors@xxxxxxxxxxxxxxx
In-reply-to: <20201113100850.GA168908@mwanda>
References: <20201113100850.GA168908@mwanda>
User-agent: Cyrus-JMAP/3.3.0-570-gba0a262-fm-20201106.001-gba0a2623


On Fri, 13 Nov 2020, at 20:38, Dan Carpenter wrote:
> This needs to call of_node_put(np) before returning if of_iomap() fails.
> 
> Fixes: e0218dca5787 ("soc: aspeed: Add soc info driver")
> Signed-off-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx>

Reviewed-by: Andrew Jeffery <andrew@xxxxxxxx>

References:
- [PATCH] soc: aspeed: Fix a reference leak in aspeed_socinfo_init()
  - From: Dan Carpenter

Prev by Date: Re: [PATCH] MAINTAINERS: rectify file patterns for NETFILTER
Next by Date: [PATCH] mm: memcg: remove obsolete memcg_has_children()
Previous by thread: [PATCH] soc: aspeed: Fix a reference leak in aspeed_socinfo_init()
Next by thread: [PATCH] clk: qcom: lpass-sc7180: Clean up on error in lpass_sc7180_init()
Index(es):
- Date
- Thread

[Index of Archives] [Kernel Development] [Kernel Announce] [Kernel Newbies] [Linux Networking Development] [Share Photos] [IDE] [Security] [Git] [Netfilter] [Yosemite News] [MIPS Linux] [ARM Linux] [Device Mapper]

Powered by Linux