On Fri, 13 Nov 2020 11:12:41 +0100, Dan Carpenter wrote: > > The spin_lock/unlock_irq() functions cannot be nested. The problem is > that presumably we would want the IRQs to be re-enabled on the second > call the spin_unlock_irq() but instead it will be enabled at the first > call so IRQs will be enabled earlier than expected. > > In this situation the copy_resp_to_buf() function is only called from > one function and it is called with IRQs disabled. We can just use > the regular spin_lock/unlock() functions. > > Fixes: 555e8a8f7f14 ("ALSA: fireworks: Add command/response functionality into hwdep interface") > Signed-off-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx> > --- Thanks, applied now with Cc to stable. Takashi