On Mon, 9 Nov 2020, Colin King wrote:
From: Colin Ian King <colin.king@xxxxxxxxxxxxx>
Currently the assignment of pointer net from the sock_net(sk) call
is potentially dereferencing a null pointer sk. sk points to the
same location as pointer msk and msk is being null checked after
the sock_net call. Fix this by calling sock_net after the null
check on pointer msk.
Addresses-Coverity: ("Dereference before null check")
Fixes: 00cfd77b9063 ("mptcp: retransmit ADD_ADDR when timeout")
Signed-off-by: Colin Ian King <colin.king@xxxxxxxxxxxxx>
---
net/mptcp/pm_netlink.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
Hi Colin and Jakub -
I noticed that the follow-up discussion on this patch didn't go to the
netdev list, so patchwork did not get updated.
This patch is superseded by the following, which already has a Reviewed-by
tag from Matthieu:
http://patchwork.ozlabs.org/project/netdev/patch/078a2ef5bdc4e3b2c25ef852461692001f426495.1604976945.git.geliangtang@xxxxxxxxx/
Thanks!
--
Mat Martineau
Intel
