On 29/10/20 15:29, Valentin Schneider wrote: >> @@ -269,17 +269,17 @@ static int sd_ctl_doflags(struct ctl_table *table, int write, >> return 0; >> } >> >> - tmp = kcalloc(data_size + 1, sizeof(*tmp), GFP_KERNEL); > [...] >> - tmp += *ppos; > [...] >> - kfree(tmp); > > Yeah, that's downright sloppy :( I can't remember which one it was in a > hurry, but I was "inspired" by another proc handler somewhere; I'll try to > find out if there's any issue in that one or if I really cannot shift the > blame elsewhere. Nope, blame is all mine.
