On 2020/10/23 19:22, Dan Carpenter wrote: > Smatch complains that "ret" might be uninitialized if we don't enter > the loop. We do always enter the loop so it's a false positive, but > it's cleaner to just return a literal zero and that silences the > warning as well. Thanks for the clean up. Minor comment below: Perhap it makes sense to limit ret scope within the for loop after returning zero. > > Signed-off-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx> > --- > drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_tm.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_tm.c b/drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_tm.c > index 15f69fa86323..e8495f58a1a8 100644 > --- a/drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_tm.c > +++ b/drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_tm.c > @@ -1373,7 +1373,7 @@ static int hclge_tm_bp_setup(struct hclge_dev *hdev) > return ret; > } > > - return ret; > + return 0; > } > > int hclge_pause_setup_hw(struct hclge_dev *hdev, bool init) >
