On Thu, Oct 22, 2020 at 10:06:59AM +0300, Dan Carpenter wrote: > The debugfs_create_dir() function never returns NULL. Normal users are > not supposed to check the return value so the correct fix is just to > delete this check. > > In the case where the debugfs_create_dir() fails, the function returns > NULL. The other debugfs function check for NULL directory and handle > it. > > Signed-off-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx> Applied. Thanks, Guenter > --- > drivers/hwmon/pmbus/max20730.c | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/drivers/hwmon/pmbus/max20730.c b/drivers/hwmon/pmbus/max20730.c > index be83b98411c7..00fea16acab4 100644 > --- a/drivers/hwmon/pmbus/max20730.c > +++ b/drivers/hwmon/pmbus/max20730.c > @@ -328,8 +328,6 @@ static int max20730_init_debugfs(struct i2c_client *client, > return -ENOENT; > > max20730_dir = debugfs_create_dir(client->name, debugfs); > - if (!max20730_dir) > - return -ENOENT; > > for (i = 0; i < MAX20730_DEBUGFS_NUM_ENTRIES; ++i) > psu->debugfs_entries[i] = i;
