On Tue, Sep 22, 2020 at 7:49 AM Markus Elfring <Markus.Elfring@xxxxxx> wrote: > > > The error return ret is not being check with an if statement and > > Wording alternative: > The return value from a call of the function “brcm_phy_start” was not checked and > > > > V2: disable clock as noted by Florian Fainelli and suggested by > > Jim Quinlan. > > Alex Dewar contributed another update suggestion. > > [PATCH v2] PCI: brcmstb: Add missing if statement and error path > https://lore.kernel.org/linux-arm-kernel/20200921211623.33908-1-alex.dewar90@xxxxxxxxx/ > https://lore.kernel.org/patchwork/patch/1309860/ > > The exception handling needs further development considerations > for this function implementation. Hello, I agree with Alex's patch. I should have suggested this at the beginning but as our upstream STB suspend/resume is not yet functional and the one-line change would have worked until we fixed suspend/resume.. But this is the proper modification. Thanks, Jim > Regards, > Markus
Attachment:
smime.p7s
Description: S/MIME Cryptographic Signature
